Daniel

Results 31 comments of Daniel

I fixed the error in #4816 because I encountered it during testing. I didn't do anything else from this issue, though.

Thanks for updating the title and PR description @fm3 :) I'll continue with restoring the 3D viewport proofreading using vertex colors once I'm back in office. I'll also have a...

> It seems to me like the libs already support adding new mags / layers to remote datasets. Therefore, maybe calling the new methods add_foreign_mag/layer might be better suited. Can...

I'm not sure whether I fully understood, but are you saying the method you introduced `add_remote/foreign_layer` can be used to add a layer from the local file system to a...

Thank you for explaining! I'll think out loud. I think the current "mental model" is that remote datasets/layers/mags are those that are not on the "same server" (accessed via file...

@MichaelBuessemeyer What do you think about my last comment? If possible, I'd like to get this merged and pulled into voxelytics in the next week, before I'm out of office...

@MichaelBuessemeyer @markbader Thank you for your work on this! I just saw that `webknossos.utils` includes an `is_fs_path` method. Could you clarify whether that's the exact opposite of the `is_remote_path` method...

@MichaelBuessemeyer @markbader Instead of commenting out the tests you can use this pytest decorator and also include the reason for the skip :) ```python @pytest.mark.skip( reason="The test is flaky on...

@MichaelBuessemeyer Sorry, I would have wanted to add a changelog entry before merging, but bulldozer was too eager. We've already spoken to Norman to reconfigure bulldozer to only merge when...