smo-shaders icon indicating copy to clipboard operation
smo-shaders copied to clipboard

Should this work out-of-the-box with Unity 2019.4?

Open DavidAntliff opened this issue 4 years ago • 3 comments

Hi, I'm working through your tutorial but I'm not able to get your example scene CompleteDemo to work with Unity 2019.4 (or 2020.3 for that matter either). I have a fresh clone of your master branch as of today.

I'm mostly presented with an overly white scene, although some trees can be seen:

image

image

When I run the scene, I seem to be rotating around a glaring white environment with obvious texture distortion and issues with face culling. Clicking the mouse buttons changes the name of the effect but there's no real visual change.

image

When importing the project I had to update ProBuilder to 4.4.0 to avoid a namespace clash, but I don't think that would cause the shaders to break.

Do you have any thoughts as to what is going wrong here? Have I missed a step somewhere? I'm using whatever the project was using originally, which is the BuiltIn RP I think.

DavidAntliff avatar Aug 04 '21 05:08 DavidAntliff

I get the same results with Unity 2021.2.13f1. Pretty sure what is happening is that OnRenderImage is no longer supported with the Scriptable Render Pipeline.

This project out of the box needs a Render Pipeline asset in order to be supported on newer versions of Unity (2020, 2021, etc.).

@daniel-ilett, any chance you could update this project to support URP (or just newer versions of Unity in general)?

kayroice avatar Feb 28 '22 18:02 kayroice

I verified that the shaders will work fine with Unity 2021.x and URP 12.x using URP_BlitRenderFeature. Anyone wanting to follow this tutorial using a more recent version of Unity and URP will need need to create a URP Render Asset and then add a URP Renderer Feature (or use the URP_BlitRenderFeature mentioned earlier) to the Render Asset they just created.

kayroice avatar Feb 28 '22 21:02 kayroice