shaders-botw-grass icon indicating copy to clipboard operation
shaders-botw-grass copied to clipboard

Fixing transform issues

Open ondra-vaic opened this issue 1 year ago • 2 comments

Hey, thank you for sharing this awesome grass shader. There is a small issue which breaks the transformations. There's an open pull request attempting to fix it already, however that breaks when the meshes are rotated. I believe this actually fixes all the issues.

The problem was, that the geometry stage receives vertices in world space but then transforms them to clip space with TransformObjectToHClip.

After: image

ondra-vaic avatar Sep 19 '23 22:09 ondra-vaic

I second that this simple change solves the problem!

BenetManzanaresSalor avatar Dec 07 '23 15:12 BenetManzanaresSalor

Thank you very much! I hope he includes this change.

DarkanVIII avatar Jun 30 '24 17:06 DarkanVIII