Daniel A.C. Martin

Results 11 comments of Daniel A.C. Martin

@marcinc: The PR doesn't actually skip the watching it just defers it until the rest of the Kubernetes resources in a multi-resource YAML file have been created / updated.

Okay. Well I can add a flag if you like. But it's worth pointing out that supporting both behaviours will complicate the code a little. In terms of changing the...

Ah, I didn't think about multiple files being deployed at once. (Didn't know that was supported!)

I've just run into this and found it quite odd. I had thought that one of the benefits of Restify was that it will do content negotiation and yet most...

I'm seeing the same problem, after updating to webpack v5.

I suspect it comes from this line: https://github.com/staylor/react-helmet-async/blob/main/src/Dispatcher.js#L60 Would be good to understand, how this might end up as `undefined`.

I believe that, for me, this was caused by a broken bundle that resulted in multiple instances of React being used.

FWIW, this still seems to be an issue. (I'm probably unusual in using Restify in this way, so I guess most people won't encounter this.) I've seen it in other...

@dougmoscrop: Thanks for reviewing that PR. Would you mind publishing when you get a chance? - That way, I can remove that workaround from my code.

This should be fixed in the next version of govuk-frontend. The next version will be the one after v4.0.1, likely v4.0.2.