Dan Harrin

Results 529 comments of Dan Harrin

Related https://github.com/filamentphp/filament/discussions/13310

Yeah I think we should do v4

Sure, please target it at v4 though

Before implementing this I would like someone to reply here and let me know what use case they have for this hook, so that I can make sure needs are...

Yeah I'm just struggling to imagine how you would use it, hence why I haven't merged it

Should you not do that when the modal is opened, `mountUsing()`? So then it still gets recorded if you close the browser instead of the modal?

Would that not be better with "Next" and "Previous" buttons in the modal footer instead of shoving each announcement in the user's face when they try and quit?

Yeah sorry guys but as per our discussion I am still not convinced this is useful, and I think the implementation is pretty tricky to catch every case where a...

There are a few plugins that do similar things to this now, and I think the implementation could end up being a little too opinionated for core, so I think...

Going to close this since there was no movement on #13642. Next step would be putting in a v4 PR for an empty state Blade component, and then opening another...