filament icon indicating copy to clipboard operation
filament copied to clipboard
verified publisher icon filamentphp

Valid nested headings

Open zepfietje opened this issue 1 year ago • 3 comments

Currently the section component uses <h3> for its headings. Similarly, table headings use <h4>.

In reality, people use nested sections and tables may be top-level components. I think it's time for Filament to support dynamically rendering the right heading element to produce valid HTML.

Not sure how feasible this is, but just wanted to create this issue for discussion, @danharrin.

Donate 💰 to fund this issue

  • You can donate funding to this issue. We receive the money once the issue is completed & confirmed by you.
  • 100% of the funding will be distributed between the Filament core team to run all aspects of the project.
  • Thank you in advance for helping us make maintenance sustainable!
Fund with Polar

zepfietje avatar Jun 17 '24 19:06 zepfietje

Related https://github.com/filamentphp/filament/discussions/13310

danharrin avatar Jun 20 '24 08:06 danharrin

Would releasing this as a bug fix in v3 be too breaking? I mean, people might directly target the heading HTML elements in their custom CSS (hence I added the v4 milestone).

zepfietje avatar Jun 20 '24 09:06 zepfietje

Yeah I think we should do v4

danharrin avatar Jun 20 '24 12:06 danharrin