Daniel Gale-Rosen
Daniel Gale-Rosen
oh weird it assigned me to this issue but not actually to review the PR. Let me add myself and review it now!
bump on this when you have a moment @rushatgabhane! Though we've got some conflicts now too, @ren-jones
how are we looking on this one? Do y'all need any help getting this over the line?
backend is merged but not yet on staging. Will let you know!
Okay backend is on staging! This should be ready to test/review. Thanks!
Hey! So this looks good - except - I didn't change the `connect` errors to be keyed by email, those are the same as before. (I also didn't change `disconnect`,...
Like, it always returns undefined for all roles? or just for auditors?
But you see them in group chats right? Asking because on the backend we send role for group chats but nothing else. Seems like it's working there for me... ...
ah okay cool then yeah, I'll see how to send roles for policy rooms. Just making sure it wasn't a wider bug!
Okay i've added the details of that change to the design doc for review!