Daniel Gale-Rosen

Results 135 comments of Daniel Gale-Rosen

Adding @MonilBhavsar and @eVoloshchak to the review based on the issue, and removing myself - but if you want another pair of eyes let me know!

Hey! Code looks good, but I'm struggling to test. I've managed to make the release build on my Simulator, and it successfully crashes in 15 seconds. I've also gotten access...

> @dangrous did you reopen the app after it crashed? Do you have a physical device you can test on? The link looks correct to me, maybe there's an issue...

Yep! Happy to. Once I get my physical device set up (the convo you're in in Slack) I can try again, since I wasn't able to get anything sent to...

Blah even on a physical device, I'm still seeing: ``` 2022-11-14 14:12:21.377011-0500 New Expensify[1984:97202] [native] Crashlytics - WARNING: Debugger detected. Crashlytics will not receive crash reports. ``` in the logs....

Interesting, I tried that and am now getting a different note in the logs (and the app isn't crashing anymore) - ```2022-11-14 14:43:00.943045-0500 New Expensify[84666:6457477] [native] Crashlytics - INFO: crashlytics...

Okay, so good/bad news. Good: I finally got it working! Successfully saw my crash reports in Crashlytics. Bad: I saw crash reports when I shouldn't have, as well (the `callFunctionThatDoesNotExist`...

hm, yeah console.log says false. Maybe it was a hot reload thing? I'll try again a couple times and see what I can make of it.

Okay it looked like that worked! I guess something wasn't fully loaded. Will look at android first thing tomorrow. Sorry this is all taking forever to test.

Okay FINALLY got this working. Android was easier to set up a release build than iOS, but it still must have cached something so I had to try a couple...