Daniel Gale-Rosen

Results 135 comments of Daniel Gale-Rosen

Okay great, that passed. Can we go ahead and merge, or are there any other moving pieces we need to wait for and or test for?

I got the test to pass once, so I think maybe it's flaky? I'm running it one more time - I'd definitely prefer not to merge with the failing test....

Hm this feels like it might be backend, but definitely open to a front end solve if we have one! Will look shortly

Trying to replicate locally, apparently it's hard to get the email summaries to send.

[Trying to get some help](https://expensify.slack.com/archives/C03TQ48KC/p1734019478809939) replicating this, once i can we can figure out the solution

Okay so I managed to reproduce finally. The issue looks like the formation of the link from the email, vs. how you get there from the app itself. I don't...

hey @Gonals it looks like you wrote the initial URL that we use for attachment email links ([here](https://github.com/Expensify/Web-Expensify/blob/94064bacfd74563020b6c329075d56eefde895e2/lib/ReportUtils.php#L2846-L2849)). any ideas on why these aren't working anymore?

Yeah hrm. Okay so I've got nearly all of what we need. I've updated the backend to use the right format: `URL_TO_NEW_DOT.'attachment?source='.$url.'&type=r&reportID='.$reportID;` This works on dev! Yay! However, I looked...

BE fix that should hopefully fix this is merged, not yet deployed