Dan Onoshko

Results 172 comments of Dan Onoshko

> Prettier library is just for rewriting the code, so everyone have the same code style. Am I right? Yes > all the code been rewriting and producing a big...

I think this PR also resolves this issue https://github.com/chartjs/Chart.js/issues/9436 If we still want to support commonjs, cjs bundle from this PR has compatible with ESM exports: ``` Chart.helpers = {...helpers};...

@kurkle Hi. Scatter and Bubble charts don't use `data.labels`, so should their tooltips also look like on rest multiseries charts?

@kurkle webpack with terser (default minifier, actually terser make tree-shake). Why it's braking change ? Public API stays the same.

@kurkle we can add, for example, swc to transpilation

my test bench: https://github.com/dangreen/chartjs-treeshaking-test

> @kurkle we can add, for example, swc to transpilation swc and even babel transpile it to side-effected code 😕

> Using esbuild? I think most others can shake assigning class properties (it can have side effects, but usually does not) https://github.com/terser/terser/issues/724 https://github.com/babel/babel/issues/5902

@kurkle Ok, it's breaking change, but it's a desirable and valuable fix. So what is the release plan?