Daniel Graña

Results 62 comments of Daniel Graña

I recently wrote a script to do this but only for gnome-terminal it is pending approval/feedback/merge at https://github.com/sigurdga/gnome-terminal-colors-solarized/pull/19

the limitless cache is true, but it never accounted for lot of memory unless you store responses on it. Looks like this change may be related to the memory issues...

@kmike +1 to use `queuelib.pqueue`. Sorry, I completely forgot to comment the ticket when we talked about it in Europython. @nramirezuy The ticket is about the "buffer" you mention, precisely...

See tentative implementation in #1440.

> @kmike , you mean Headers should store keys as-is and still allow case-insensitive lookups? I am not sure, the change is backwards incompatible and likely less performant than current...

@eliasdorneles : do you recall XPathHtmlSelector, XPathXMLSelector, CSSHtmlSelector...? I am not fond of using different class for JMESPath, we ditched it already in favour of a single class with different...

> There are useful use cases for chaining (e.g. processing data- attributes), but I think they don't worth extra complexity we may introduce to support them. This is exactly what...

@Digenis I don't think there is such complexity for users extending Selector class, I can understand there was bit when CSS selection method was added because behind the scenes it...

Ok! I must admit Option 2 is complex because we are parsing the DOM in Selector constructor but option 1 is still compelling, isn't it? :)

We can delay the parsing of the DOM until the first selection method is called. That will trigger json, xml, html parsing on demand.