Dan Gowans
Dan Gowans
Renaming started me down the right path, but still after renaming the file extension to "jar", double-clicking it in Windows Explorer still didn't work for me. What did was opening...
Try this. ```css [data-tooltip] { border-bottom-width: 0 !important; } ```
@dependabot rebase
@dependabot rebase
@dependabot rebase
@dependabot rebase
Running the recommended ruleset over my code base, I'm finding code like this: ```js containerEle.getElementsByTagName("form")[0].addEventListener("submit", submitFunction); ``` The `unicorn/prefer-query-selector` rule transforms that line to: ```js containerEle.querySelectorAll("form")[0].addEventListener("submit", submitFunction); ``` It's valid,...
> > > I wonder if there are other anti-patterns with `querySelectorAll` we could catch and then make this rule more general and named `no-incorrect-query-selector` or something. Maybe if the...
> `document.querySelectorAll('#foo')` Definitely like this one. > `document.querySelectorAll('[data-foo=2]')` Not sure if this one has the same goal of avoiding selecting a single element with `querySelectorAll`. Possibly a second rule like...
If we're considering inefficient selectors, something like this may qualify. ```js document.querySelectorAll("select").querySelectorAll("option") ``` Could be better written as: ```js document.querySelectorAll("select option") ```