Daniel Esteve

Results 5 comments of Daniel Esteve

The phpstan issues seems to be unrelated to this PR. Also some tests seem to be a bit flaky, maybe increasing timeouts would help. https://github.com/stomp-php/stomp-php/blob/3a9347a11743d0b79fd60564f356bc3efe40e615/tests/Functional/ActiveMq/ClientTest.php#L82

Hi @jmglsn, @staabm. Can you take a look at the changes?

No problem @jmglsn, thank you for your time.

Sorry to hear that. Hope everything is ok. Of course personal life should always come first. Wish you all the best.

Hi @jmglsn, thanks for looking into this. Yes, i can confirm that using a heartbeat > readTimeout seems to work fine.