Dane Powell
Dane Powell
Thanks, will do on Monday
@Nyholm can you help me understand why tests for this pass on my local (`./phpunit src/Symfony/Component/Filesystem/`) but fail in CI? It appears that the Finder component is missing in CI.
Thanks! This is ready for review. I don't believe the remaining failure is related to this PR.
Okay, I've rewritten this in a way that's backwards-compatible.
I'm happy to take any approach you decide, just let me know how you'd like to proceed.
I rebased on 6.1 and tests are passing again.
Thanks, I've addressed all feedback. Just to confirm, this will be backported to 5.4 after being merged into 6.1?
I'd argue this is a bug, not a new feature. The expected behavior if `$options['delete'] == true` is to delete files in the target directory. But the actual behavior is...
Okay, we won't backport it. Any chance of getting this merged? Anything at all I can do to help?
@fabpot the problem is that iterators contain absolute paths. If the origin and target directories are different, you _must_ have separate iterators for each. Unless you know of some way...