Dan Davison

Results 601 comments of Dan Davison

@spacether tangential to this ticket, but we recently added an official Pydantic data converter to the SDK: https://github.com/temporalio/sdk-python?tab=readme-ov-file#pydantic-support If you use that data converter you'll get Pydantic's enum support (which...

Hi @rfwroo. Hm. Can you give platform details, and git version? Does it really only occur with those two commands, not with `git diff` etc? Do they always fail, or...

Hi @simokhwang, you can do `hunk-header-style = omit`. However, is there something you'd like to display at that location instead (like some separating characters for example)? Otherwise, won't it be...

@simokhwang, thanks. Here's a quick comparison of some possible customizations, including one that is equally compact with default git diff. Does this help? ## Vanilla git diff (3 lines) ```...

> a lot of the time the "class name" is actually just the first line of the hunk and it makes no sense to draw a box around it -...

> Adding an option to insert a constant separator for users who just want to sidestep the whole issue sounds like a good idea to me. Yes, I agree. Seeing...

Hi @jonathanpoelen, thanks for this. It's similar to https://github.com/dandavison/delta/issues/485, but that issue is focusing on the case of git diffs which can of course have multiple files and thus multiple...

Hi @jjmaestro. `.gitattributes` support sounds interesting! At the moment the best we have is `--default-language`. Note that this can be set on a per-repo basis: https://github.com/dandavison/delta/pull/1655#issuecomment-2001999025

Yes, if you'd like to work on this that would be great! Let's get the design agreed on here. cc @th1000s. > a `--languages` config that accepts a map of...

Hi @spacether, thanks for the input here. Before getting into implementation, can you expand on the problem that you want to see solved and what you see as the requirements...