Dan Davison

Results 601 comments of Dan Davison

I've opened https://github.com/temporalio/sdk-python/issues/611 to have the SDK raise an exception with a more helpful error message -- thanks for the report!

https://github.com/temporalio/sdk-python/actions/runs/10403635533/job/28817496590?pr=609 ``` FAILED tests/worker/test_activity.py::test_sync_activity_process_non_picklable_heartbeat_details - assert "Can't pickle" in "AttributeError: Can't get local object 'picklable_activity_non_pickable_heartbeat_details..'" ```

https://github.com/temporalio/sdk-python/actions/runs/12930726515/job/36062930291?pr=739 ``` poe test -s --workflow-environment time-skipping --junit-xml=junit-xml/3.13--macos-intel--time-skipping.xml ``` ``` FAILED tests/worker/test_workflow.py::test_unfinished_handler_on_workflow_termination[-cancellation---no-wait-all-handlers-finish---not-dynamic---late-registered---signal-] - Failed: Timeout >600.0s ```

https://github.com/temporalio/sdk-python/actions/runs/12939859391/job/36092964653?pr=739 ``` =========== 342 passed, 10 skipped, 9 warnings in 316.04s (0:05:16) ============ FATAL: exception not rethrown Error: Process completed with exit code 250. ```

``` FAILED tests/worker/test_workflow.py::test_workflow_patch_memoized - Failed: Timeout >600.0s ``` https://github.com/temporalio/sdk-python/actions/runs/9745494374/job/26893565606?pr=566 https://github.com/temporalio/sdk-python/actions/runs/9745832979/attempts/1?pr=567

Hi, thanks for the report. Perhaps delta can be modified to behave differently when `--name-only` is in effect; either by inferring that from the output, or by inspecting the calling...

Nice, very interesting! - I'm sure you considered this but is supporting `delta git $subcommand` a possibility also? - Are there any parse ambiguity challenges, e.g. if someone tries to...

> "show", "log", "diff", "grep", "blame" > Are there any other useful commands? The ones that are coming to mind are `add` for `git add -p`, and `reflog` and `stash`...

> Also, can you check why the rg test fails on macOS? It fails because of https://github.com/dandavison/delta/blob/acb7c1294397c8c2ccd1a68c786261ea6dc22dd3/src/subcommands/generic_subcmd.rs#L127 https://docs.rs/grep-cli/latest/grep_cli/fn.resolve_binary.html > On non-Windows, this is a no-op. This API has always seemed...

I use `zsh` and have `eval "$(delta --generate-completion zsh 2>/dev/null)"` in my shell config. It looks like there might be a shell completion challenge relating to this PR: normally, a...