Dan Davison

> I didn't realize this was ready for review? Is the work complete here? It will help to have lots of manual testing of this branch, from users with different...

I vote for deprecating `fetch`, and introducing a top-level `http` command, with HTTP verbs as sub-commands.

@sandwoodK would you suggest adding a `--protocol-version` flag to be explicit about that?

Actually, this bug is not specifically related to underline, it seems to involve other ANSI escapes and non-ASCII characters. E.g. here there seems to be bad handling of the non-ASCII...

Hi @zhiburt, great! I don't know if this is helpful, but just in case: [delta](https://github.com/dandavison/delta/blob/master/src/ansi/iterator.rs#L45) contains a [library](https://github.com/dandavison/delta/blob/master/src/ansi/iterator.rs#L45) for parsing ANSI escape sequences and OSC terminal hyperlinks: you give it...

> It would interesting to compare https://github.com/dandavison/delta/blob/master/src/ansi/iterator.rs#L45 and https://lib.rs/crates/ansitok which relays on nom. Ah, nice you've written an ANSI parser library. Definitely, I'll have a go at making that comparison...

I've put up a fix for this as a patch against tabled v0.8.0, using the ANSI parser library from Alacritty, which handles OSC8 hyperlinks (code taken from delta): https://github.com/zhiburt/tabled/pull/223 The...

Excellent, thanks for working on the benchmarking! I'd be interested to see the benchmarking code at some point.

I'll fix those test failures.

Hi @whitphx, the tests should pass now. The `yank` portion of the tests is commented out, since that was not passing (I'm not sure why yet -- `yank` does appear...