Dana Myers

The SX1276 datasheet warns that max duty cycle at +20dBm is 1% - suggest running max of +17dBm from the chip itself. I also note that the radiohead library seems...

Eliminate do_div, floating point and malloc()

4

Perhaps you'd like to try these changes, which probably reduce the AVR binary size quite a bit and perhaps improve performance. I admit I have not yet compiled or tested...

From pll_calc(): ``` /* Factor calibration value into nominal crystal frequency */ /* Measured in parts-per-ten million */ ref_freq += (uint32_t)((double)(correction / 10000000.0) * (double)ref_freq) ``` Fixed-point is perhaps more...

UC51x decoder doesn't correctly handle unknown/new data items

5

The UC51x decoder is structured with if {} else if {} else if {} else break. We had a older decoder installed on ChirpStack and did not realize it. Newer...

Why are there separate Chirpstack (v3) and ChirpStack v4 decoders? Single decoder works

4

There's no need for two different decoders, especially since this creates the chance of error where the actual payload decoding does not match. Chirpstack v3 calls this function: ``` //...

Initial update to FW1.3 - probably requires more changes, esp to lora_app.c ?

First whack at v1.3 FW update

4

Initial update to FW V1.3 - not tested. Seems to build. Probably requires more changes in lora_app.c