Daniel Garvey
Daniel Garvey
> * [ ] CSE (common subexpression elimination) ok I had a matching intuition for what it did but didnt know that acronym XD
probably unrelated but this is with your remove-jit-attr branch
@benvanik ok after moving the global to the top it compiles.
@stellaraccident this is happening after using externalize_module_parameters(nn.module) from https://github.com/iree-org/iree-turbine/blob/main/shark_turbine/aot/support/ir_utils.py#L173 I thought we insert global at the start of the moduleOp, am I misunderstanding something?
I think we should probably fix the underlying problem in cmake that is causing the divergence of paths for different users. Can you two confirm the build command you use...
Looks like there is some underlying execution engine change needed to support operation versus module?
@hanhanW identified `[0, 18, 63, *]` and `[0, 18, 1389, *]` are NANs
Any reason it needs to be added as xfail?
Sorry for the slow review. If you resolve the merge conflict I'll run the ci and approve.
wanted to double check my understanding and come up with some test cases: This is a case where we cannot fuse, right? Because the resulting concat isn't semantically equivalent. (I...