torch-mlir icon indicating copy to clipboard operation
torch-mlir copied to clipboard

[fx] Use module Operations instead of Module.

Open stellaraccident opened this issue 1 year ago • 2 comments

This was only used in certain advanced uses of the API that want to build into their own module. The MLIR Module class is an awkward/restrictive way to require this to go as only some things will have it. Just switch everything to be based on a module Operation.

Also adds an optional visibility specifier to entry points that construct a function.

stellaraccident avatar Mar 22 '24 02:03 stellaraccident

Looks like there is some underlying execution engine change needed to support operation versus module?

dan-garvey avatar Mar 22 '24 16:03 dan-garvey

Ugh. There is stilly tech debt in the ExecutionEngine that needs to be excised...

stellaraccident avatar Mar 22 '24 16:03 stellaraccident