Damir Vodenicarevic

Results 119 comments of Damir Vodenicarevic

@Eitu33 for the executed ops hash (and state hashes in general), it is important that the hashes are computed only at the final state. Computing them for speculative states would...

> Third one: ![image](https://user-images.githubusercontent.com/89928840/191995077-2e0271ba-3c8a-4186-a366-98e3ae34db02.png) this one towards the end of cycle 92 (period 119/128)

> Saw another one today: > > ``` > 2022-09-23T09:33:14.448528Z INFO massa_bootstrap::client: Bootstrap from server 51.75.60.228:31245 failed. Your node will try to bootstrap from another server in 60s. > 2022-09-23T09:34:14.450434Z...

I was able to replicate it myself multiple times (had to try bootstrapping 3 times for it to work): ``` 2022-09-25T12:21:54.256133Z  WARN massa_bootstrap::client: Error while bootstrapping: pos error: Overflow...

Hi ! 1. there is no good reason to fuse them... On the contrary, since we have a clear separation of concerns (the two factories don't have the same function...

> > the two factories don't have the same function > > They both have the function of producing objects at a given slot, they also do pretty much the...

Basic preliminary correction made in https://github.com/massalabs/massa/pull/3010/commits/a18239f9108dd703a119ddd0202bb21d7ae3578f to reduce load.

@gterzian there are some unadressed comments in this PR. Can you address them all ?

I was able to replicate only the speculative mismatch bug: ``` 2022-10-20T20:54:45.115728Z INFO massa_consensus_worker::consensus_worker: Started node at time 2022-10-20T20:54:45Z, cycle 436, period 55892, thread 27 2022-10-20T20:54:45.119505Z INFO massa_protocol_worker::protocol_network: Connected to...