Damir Vodenicarevic

Results 121 comments of Damir Vodenicarevic

The performance of the current version is good. Closing

Oh ok, then it should be OK for now ! we can merge the correction

We won't do this for now

Wallet module needs updating

> I've answered you about the salt size on the other PR. > > About the encoding json vs our proper. I don't know why it wasn't JSON at start...

> The standard only supports one keypair by file so we will need to have folders to keep maintaining the multi keys in wallet on client and staking. Is that...

One idea would be to extend what I explained here: https://github.com/massalabs/massa/pull/3417#issuecomment-1397585704 with extra entries in the case of the address enum: ```rust enum Address { EOA_V1(EOA_V1_Address), EOA_V2(EOA_V2_Address), SC_V1(SC_V1_Address), SC_V2(SC_V2_Address) }...

So if I understood correctly, we're implementing this: ```rust enum Address { SCAddress(SCAddress), UserAddress(UserAddress) } // ser/deser to/from bytes/bs58check implemented for Address only // when serializing, use the following format:...

I think A would be better in any case, because we also want to balance resources used by different connected nodes. Here are some things that need to be factored...