massa icon indicating copy to clipboard operation
massa copied to clipboard

Split `massa-client` code between REPL abstractions (external crate) and our business commands (that relay on `massa-models`)

Open AureliaDolo opened this issue 3 years ago • 6 comments

To make external contributions easier (the Russian client looks pretty)

AureliaDolo avatar Dec 07 '21 16:12 AureliaDolo

@yvan-sraka @adrien-zinger I'm quite not sure on how to do that. Is it possible to fork only a part of a repo ?

AureliaDolo avatar Dec 08 '21 11:12 AureliaDolo

There is multiple possibilities, maybe we want to keep the source code here because when we tag the CI builds a release for the client and for the node. A solution, for me, would be to use a submodule with git. But I want to check if the clone command wont be altered.

Maybe the CI can also build another repo on tagging. It would be better.

adrien-zinger avatar Dec 08 '21 11:12 adrien-zinger

I vote for this! We could just have an external repo and use cargo install to make it available to CI :)

yvan-sraka avatar Dec 08 '21 13:12 yvan-sraka

sounds good but implies also splitting away "massa-models" which is a dependency the client shares with massa-node. I'm afraid we are heading for too much complexity with this. Marking it for refactoring discussion tho

damip avatar Jan 17 '22 05:01 damip

@AurelienFT @yvan-sraka was this done ?

AureliaDolo avatar Mar 30 '22 14:03 AureliaDolo

@AurelienFT @yvan-sraka was this done ?

The PR is still open so I don't think

AurelienFT avatar Mar 30 '22 15:03 AurelienFT

This was done in massa-sdk I think. Closing ?

damip avatar Jun 05 '23 09:06 damip