Damien Retzinger

Results 192 comments of Damien Retzinger

Angular has an example here: https://angular.io/tutorial/first-app#step-1---identify-the-version-of-nodejs-that-angular-requires with the word `node.js` interestingly, it's different on mobile versus desktop. I don't mind this style: ![Screenshot_20240228-091346.png](https://github.com/graycoreio/daffodil/assets/9029654/9ab6738e-7250-4b59-9b57-a430156755d1)

We use https://github.com/jonschlinkert/markdown-toc to generate these here: https://github.com/graycoreio/daffodil/blob/develop/tools%2Fdgeni%2Fsrc%2Ftransforms%2Fdaffodil-guides-package%2Freader%2Fguide-file.reader.ts We would have to play around with markdown-toc to see if we can make it escape this content.

@xelaint discussed this and this is no longer a requirement.

@griest024 can you clarify this a bit? If I navigate to `/test-url?test=123123#test` should I be redirected to `/failure-route?test=123123#test` or `/failure-route`

There are some aspects of the example modules that can be removed. I'm not entirely sure what is required by `@angular/elements` and their respective modules. I know for certain that...

These examples should instead be in a new package called `@daffodil/design-examples`.

This is now doable: It would entail: - Make a new package called `@daffodil/design-example` - Move all of the contents of `@daffodil/design/*/examples` to this package - Add a dependency of...

@mohitvermalifecell can you provide your Dockerfile? Additionally, can you provide a sample output of the following: ```bash docker-compose logs your-magento-container ``` Or equivalent container logging command i.e. `kubectl logs -f`...

I haven't re-reviewed this yet, but please do not merge it until I do.