daffodil icon indicating copy to clipboard operation
daffodil copied to clipboard

feat(design): expand selected tree items on initial render

Open griest024 opened this issue 1 year ago • 7 comments

PR Checklist

Please check if your PR fulfills the following requirements:

  • [x] The commit message follows our guidelines: https://github.com/graycoreio/daffodil/blob/develop/CONTRIBUTING.md#commit
  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Fixes: #2931

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

griest024 avatar Jul 23 '24 18:07 griest024

@xelaint can you review the behavior to make sure that you're happy with it?

griest024 avatar Jul 23 '24 18:07 griest024

I'm not sure if I like the scroll to view behavior. Can we remove that for now?

xelaint avatar Jul 23 '24 18:07 xelaint

I'm not sure if I like the scroll to view behavior. Can we remove that for now?

okay removed for now but the user can easily end up in a position where they cannot see the active item on initial render

griest024 avatar Jul 23 '24 19:07 griest024

@xelaint note that the focusing behavior of tree item actually appears to scroll the element into view. This doesn't work for deeply nested items though (docs/packages/search/driver/federated)

griest024 avatar Jul 23 '24 19:07 griest024

The UI LGTM.

xelaint avatar Jul 26 '24 13:07 xelaint

I haven't re-reviewed this yet, but please do not merge it until I do.

damienwebdev avatar Jul 29 '24 14:07 damienwebdev

bump @damienwebdev

griest024 avatar Sep 16 '24 20:09 griest024

this just doesn't work, we'll need a different solution

griest024 avatar Nov 28 '25 19:11 griest024