Damian Tomczak

Results 7 comments of Damian Tomczak

I can't get rid of treating the warning as an error. Can anyone help? ![Screenshot from 2022-06-12 02-41-20](https://user-images.githubusercontent.com/43729842/173209546-4bf67157-8b9b-4d7f-a402-7622aabb8241.png) For example, I tried to get rid of the error by "resetting"...

Unfortunately it did not help: ![Screenshot from 2022-06-12 10-42-36](https://user-images.githubusercontent.com/43729842/173225003-382b911d-7e4c-479e-a904-6d3f56520a57.png)

This doesn't help either: ```cmake string(REPLACE " -Werror" "" CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS}") string(REPLACE "-Werror=class-memaccess" "" CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS}") add_subdirectory(${PHYSX_PATH}/compiler/public externals/physx) string(REPLACE "-Werror=class-memaccess" "" CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS}") string(REPLACE " -Werror" "" CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS}") ```

> Since which version? It might make sense to have a pre-processor switch. Since 8.0.34 Yeah, it makes sense, I fixed it.

> @damian-tomczak It seems that there is an unwanted `#endif` around line 91 > > ``` > #if MYSQL_VERSION_ID < 80034 > if (config->auto_reconnect) > { > my_bool my_true{true}; >...

> @damian-tomczak If I understand correctly, they are deprecating not just the reconnect option, but the reconnect functionality as a whole. Here https://dev.mysql.com/doc/c-api/8.0/en/c-api-auto-reconnect.html they say the following > > >...

Honestly, I don't like really my proposition. But already on windows there are plenty of warnings: ``` Severity Code Description Project File Line Suppression State Warning C4244 'initializing': conversion from...