Mike Dame

Results 391 comments of Mike Dame

It sounds like the ask is to be able to exclude a pod from eviction if it has a `nodeName` set? ie, similar to how we don't automatically evict pods...

> @a7i @ingvagabund @damemi with the new framework/plugin approach, this PR could be a new custom plugin, am I right? Is this PR now obsolete with the latest changes in...

Fyi there is some prior discussion about custom metric labels in https://github.com/kubernetes-sigs/descheduler/pull/859

I checked with some folks who know Prometheus a little better than me, and it sounds like our concerns from #859 are valid. Specifically, a metric with custom/dynamic labels could...

@seanmalloy if it is not too much work for us to fix, I think it would be better treated as a bug. We should ideally not be dependent on GOPATH...

/remove-lifecycle stale can we confirm if this is still an issue?

@pravarag yeah double checking this could be good, sorry we lost track of your PR

> To do leader election, it would have to create a lease. Which I would expect in dry-run mode that no resources are affected (only queried). I'm not entirely sure...