Mike Dame

Results 391 comments of Mike Dame

Hi, could you please post your issue in English?

/cc @RyanDevlin (if you have the time) The description seems reasonable to me at first glance, do you have any opposition? You know the nodefit code best

Hi @uniemimu, I'm very sorry about the delay. Kubernetes and its subprojects (like this one) are maintained by a significant number of volunteers, many of whom review issues and PRs...

This is a tough one, but it's not just entirely my call 🙂 I agree with @uniemimu that the default doesn't necessarily have to be the same for all strategies....

Adding those options to NodeFit sounds good to me, but maybe we should split that into a separate follow-up task after converting the current NodeFit to a plugin. Then at...

I think the 2 big things are configuration and plugins. So, to start I would propose two main subtasks: * Finalize plugin API * Convert existing strategies to plugins Both...

> But the idea is also to make this project stop reading from files and be a controller reading CRDs from your cluster, am I correct? (with informers and all...

> I assume the v1alpha2 from the proposal is already good enough since we did not get any more comments on it? Yup, we're going ahead with the proposed design...

@pravarag feel free to claim some and start opening PRs to move them. I think @ingvagabund is on vacation right now, so we won't be able to update the list...

I am just suggesting that, since those metrics will have to be calculated somewhere, doing it in podEvictor makes sense because it already has access to the information. Metrics can...