Damiano Donati
Damiano Donati
Re-adding LGTM after rebase /lgtm
/cc @nojnhuh @mboersma @jackfrancis
/remove-lifecycle stale
@enxebre @bryan-cox @patrickdillon is this something you are still interested in? Is it covered by https://github.com/kubernetes-sigs/cluster-api-provider-azure/pull/5552 ?
LGTM so far. @barbacbd would you be also able to update the experimental MachinePool to export/support this new disk type? Thanks. https://github.com/kubernetes-sigs/cluster-api-provider-gcp/blob/e6db2b72de1e436da4b14fd3fd1f97ea92de1395/exp/api/v1beta1/gcpmanagedmachinepool_types.go#L32-L42 Other than that I think I'm happy with...
@cpanato happy to remove the hold and get this merged?
/reopen It'd be still be nice to see this merged.
/reopen It'd be still be nice to see this merged.
Any movement on this one @barbacbd