Damiano Donati
Damiano Donati
I also think this work would be quite valuable. I commented on something similar here https://github.com/tinkerbell/hook/issues/45#issuecomment-912701618 for reference.
Looks like it has been update now, might need a re-review.
It would be good to get this merged.
Hey @CecileRobertMichon @jackfrancis thanks for your patience here, I finally got around to get back to this again and I've updated it to include the API changes to `AzureMachinePool`s. Thanks.
Hey @willie-yao, thanks for the review. I've included your suggestions.
I think this would be handy, glancing at the UI and finding out the firmware version seems useful and would have helped me also recently figuring out a certain firmware...
@cartermckinnon do you have any thoughts on this one? Thanks!
Sure @kmala. By default when we install Kubernetes we create a worker security group (SG1), which we then tag for CCM ownership. Then we let users create extra security groups...
Great! Thanks @kmala & @cartermckinnon How do you think it is best to proceed here to implement this?