Lee Hinman
Lee Hinman
Thanks for the feedback. Are you talking about parsing JSON into integers, or parsing Java integers using Jackson's long functionality? Perhaps you can show a snippet describing the issue you're...
Yes, they are: ``` user=> (class (decode "1234567890")) java.lang.Integer user=> (class (decode "12345678900")) java.lang.Long ``` I believe this is something coming from Jackson, see: ``` clj JsonToken/VALUE_NUMBER_INT (.getNumberValue jp) ```...
Cheshire doesn't use jackson-databind, which is a tool for serializing plain Java objects into JSON and back, it just uses the core. I don't currently know of a way to...
> Is there an obvious way to implement this with the existing cheshire design? Not that I can immediately think of, I will have to experiment to see if there...
> I remember that options are passed around as first-class args, and so having an extra option means expanding the signatures everywhere :/ I'd need to check the performance hit...
Okay, remember not to use destructuring as that (unfortunately) causes a big performance hit.
I haven't dug into why it's slower yet, only that it was slower in benchmarks (heck, maybe Clojure has caught up and it's better in recent versions?), so it would...
> Okay I have some code here that seems to work Great, thanks! No guarantees for when I will be able to look as my wife just had a baby...
@gfredericks I finally had a second to check out your branch. Performance-wise it looks good to me, would you be able to open a PR for moving to it?
@pcarlisle thanks for pointing this out to me, I'll take a look!