cheshire icon indicating copy to clipboard operation
cheshire copied to clipboard

parse-stream rejects types that JsonFactory.createParser accepts

Open pcarlisle opened this issue 10 years ago • 2 comments

Because of the type hinting, parse-stream requires a Reader to be passed in. The createParser method in Jackson will accept an InputStream, and it would be nice if it were possible to pass that in directly without having to create a Reader. The jackson docs at http://wiki.fasterxml.com/JacksonBestPracticesPerformance strongly suggest not creating a Reader before calling createParser if you already have an InputStream. If you create a reader then you don't get the encoding detection that Jackson has.

pcarlisle avatar Mar 01 '16 01:03 pcarlisle

@pcarlisle thanks for pointing this out to me, I'll take a look!

dakrone avatar Mar 01 '16 23:03 dakrone

I went down the path of trying to make this and other changes suggested in the best practices, but it breaks a lot of things. This will take longer to implement than I had expected

dakrone avatar Apr 10 '16 03:04 dakrone