Loong Dai

Results 145 comments of Loong Dai

v1.46.2 output: ``` pilot/pkg/config/kube/crdclient/cache_handler.go:20: File is not `gci`-ed with --skip-generated -s standard,default,prefix(istio.io/) (gci) pilot/pkg/config/kube/crdclient/cache_handler.go:25: File is not `gci`-ed with --skip-generated -s standard,default,prefix(istio.io/) (gci) pilot/pkg/config/kube/crdclient/cache_handler.go:26: File is not `gci`-ed with --skip-generated...

Close now since no plan to fix, unless more users require it.

@howardjohn I think you can try without `goimports`, since its import completion is useless in most cases(IDE will do it, checking it in CI is unnecessary, and any import missing...

@howardjohn I am working on compatible with `goimports`, also I want to know how you use GCI, single or within `golangci-lint`?

@howardjohn @avorima could you give the smallest GO file to reproduce it?

@martinhsv Hi, where would be the best place to post if I have completed implementation for WASM? A new dir named `wasm`?

I will post a PR soon and hope it can be merged.

We have created a project https://github.com/intel/modsecurity-wasm-filter which introduce ModSecurity into Service Mesh.

We are from the same team, you can check the PR and do some try, not sure it is the only way.

Please update tests to cover this case.