components-contrib
components-contrib copied to clipboard
dapr
Handle errors from parallel mode
It seems that errors in the parallel mode cannot be caught: https://github.com/dapr/components-contrib/blob/v1.6.0/pubsub/rabbitmq/rabbitmq.go#L423
Based on https://github.com/dapr/components-contrib/pull/576
Hi @daixiang0, I have updated the tests. https://github.com/dapr/components-contrib/pull/1482/commits/8cb1052e6b19d2e6aab5ee5b22ca9976fae743b9
@gdlcf88 Please fix linter issues.(You can run gofumpt -e -d pubsub/rabbitmq/rabbitmq_test.go to see details)
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!
This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!
This is very useful PR @gdlcf88. Thanks!
@daixiang0 can you please review this?
The pubsub.rabbitmq certification test is failed all the time, can you please look into this?
The pubsub.rabbitmq certification test is failed all the time, can you please look into this?
Log
2022-05-21T07:06:26.6486731Z [36;1m echo "::error:: No certification test file was found for component pubsub.rabbitmq"[0m
certification.yml
# Fail the step if we found no test to run
if grep -q "\[no test files\]" ${{ env.TEST_OUTPUT_FILE_PREFIX }}_certification.json ; then
echo "::error:: No certification test file was found for component ${{ matrix.component }}"
exit -1
fi
@Taction - Sorry, I am not sure what's wrong with this PR. Could you please help?
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!
This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!
This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!
Codecov Report
Merging #1482 (c9dadcb) into master (a69b9b9) will increase coverage by
0.08%. The diff coverage is71.76%.
@@ Coverage Diff @@
## master #1482 +/- ##
==========================================
+ Coverage 37.62% 37.70% +0.08%
==========================================
Files 192 192
Lines 23982 24026 +44
==========================================
+ Hits 9023 9059 +36
- Misses 14193 14199 +6
- Partials 766 768 +2
| Impacted Files | Coverage Δ | |
|---|---|---|
| pubsub/rabbitmq/rabbitmq.go | 60.00% <71.76%> (+2.58%) |
:arrow_up: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!
This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!
This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!