Daira-Emma Hopwood

It doesn't really matter because the note ciphertext will be undecryptable by anyone (and so these notes cannot be distinguished by the distribution of `rseed`, which varies pre- and post-Canopy)....

The size of rendered math in ZIPs is inconsistent between reloads

2

Screencap of part of [ZIP 221](https://zips.z.cash/zip-0221) in desktop Chromium ("Version 80.0.3987.162 (Developer Build) built on Debian 10.3, running on Debian 10.4 (64-bit)"):  and after a reload: 

https://github.com/bitcoin/bips/blob/master/bip-0044.mediawiki#account-discovery

change uses of StringIO

6

E.g. `[c]StringIO.StringIO` should be changed to `six.BytesIO`. (moved from https://github.com/mitsuhiko/python-modernize/issues/17 )

use six.moves to handle imports from urllib, urllib2 and urlparse

1

E.g. ``` from urlparse import ParseResult ``` => ``` from six.moves.urllib.parse import ParseResult ``` and ``` import urlparse urlparse.ParseResult ``` => ``` import six.moves.urllib.parse as urlparse urlparse.ParseResult ```

wrong handling of multiple unicode literals when --six-unicode is used

1

If one has: ``` foo(u'.........' u'.........') ``` it gets converted to: ``` foo(six.u('........') six.u('........')) ``` that obviously does not work, better would be: ``` foo(six.u('.........' '.........')) ``` (moved from https://github.com/mitsuhiko/python-modernize/issues/9...

tuple parameter unpacking not removed for some lambdas

5

``` d.addCallback(lambda (rc, out, err), fn=fn: self.failUnlessEqual(out, fn * 1000)) ``` I would have expected this to be changed to something like ``` d.addCallback(lambda rc_and_out_and_err, fn=fn: self.failUnlessEqual(rc_and_out_and_err[1], fn * 1000))...

instead of xxx_todo_changeme, use a name based on the original variables

2

E.g. instead of ``` - def _got_root((root, path)): + def _got_root(xxx_todo_changeme): + (root, path) = xxx_todo_changeme ``` use ``` - def _got_root((root, path)): + def _got_root(root_and_path): + (root, path) =...

import statements should be after any shebang line

8

``` +from __future__ import print_function #!/usr/bin/env python ``` Imports should only be added after any initial lines that are either blank or start with #. That would account for copyright...

'import six' can be after its first use

6

``` $ cat test.py u"artificial example" import sys $ python-modernize --six-unicode test.py [...] @@ -1,2 +1,3 @@ -u"artificial example" +six.u("artificial example") import sys +import six ``` which doesn't work because...