Daeyeon Jeong comments

Results 24 comments of


                                            Daeyeon Jeong

stream: fix `isDetachedBuffer` validations in `ReadableStream`

@aduh95 Applied the suggestions, PTAL.

test: update WPT runner

I also feel hard to change something related to web compatibility since regressions are not detected with the current runner. Hope that this PR gets progressed.

stream: improve view validation on `ReadableStreamBYOBRequest.respondWithNewView()`

Rebased since `test/wpt/status/streams.json` is updated in https://github.com/nodejs/node/pull/43455.

Nominating @daeyeon as a collaborator

I'm deeply honored. Thanks for nominating me!

Logo creation

No update for a long while. Please open this again if necessary.

process: add `code` validation in `process.exit()`

IMHO, if there aren't any other node APIs that operate like this way, for consistency, semver-major seems convincing.

process: add `code` validation in `process.exit()`

@aduh95 @tniessen Thanks for the review. I removed the range restriction, PTAL.

process: add `code` validation in `process.exit()`

@RaisinTen Thanks for explaining the deprecation procedures and the search result. I will create a new PR.

process: add `code` validation in `process.exit()`

@BridgeAR Applied your view. Thanks!

process: add `code` validation in `process.exit()`

@aduh95 Thanks for the heads up. I updated `process.md`. Please let me know any other docs left.