Dimitrij Drus

Results 95 comments of Dimitrij Drus

Hello everybody. @lukestoward: Thank you also from my side for the great explanation. FMPOV there are some things missing. Or I just oversee these in the discussion above. Let me...

@lukestoward > Then part 3, the client being granted or denied an access token etc. will proceed. Hopefully this is clear. This is clear ;) > One problem I see...

You're very welcome 😉 > This makes me question whether having this challenge actually offers us any additional benefit? The idea was to reuse the patterns already implemented by hydra...

@aeneasr: It would be great if you could show more involvement ;) here. We urgently need support for the Device Authorization Code Flow. I sketched the preferred implementation approach from...

@aeneasr, @lukestoward: Thank you for this information. But what is the plan? In our (@lukestoward) last "discussion" (see above), you wanted to digest on "my" proposal. The issues I (my...

@luna-duclos: I would really appreciate, if you take a closer look. We need this enhancement to have the traces properly displayed in our APM system. Thank you in advance.

@luna-duclos: I know, there are many changes, nevertheless I appreciate if you could take some time for a review. @fho: Your changes from https://github.com/luna-duclos/instrumentedsql/pull/45 are also part of this PR....

@zepatrik: It would be great if you could take a look at `event_manager_default.go:64:27`. I'll try to resolve the other one by myself

Even the updated code compiles, there is an issue with the updated golang version (required by the current x version and also for making use the embed directive). Starting with...

I already had a chat about it with @aeneasr and started a branch to implement the idea described above. There is however a dependency to ory-x, on which I started...