dadocsis

Results 9 comments of dadocsis

I am wrapping up pr to implement custom auth handlers similar to the requests package. I am also adding a response event hook where the auth handler could be registered...

See issue 434 https://github.com/aio-libs/aiohttp/issues/434

Correct. Right now I am just adding a response hook. Looking at the Digest Auth class I do not see where it needs the "before" hook. The response hook would...

> This seems to have changed in a recent release. Here's what worked for me: > > ```js > const jsdomUtils = require('jsdom/lib/jsdom/living/generated/utils'); > const jsdomFileList = require('jsdom/lib/jsdom/living/generated/FileList'); > function...

> > This seems to have changed in a recent release. Here's what worked for me: > > ```js > > const jsdomUtils = require('jsdom/lib/jsdom/living/generated/utils'); > > const jsdomFileList =...

Would it make sense to add event hooks similar to the requests package? http://docs.python-requests.org/en/master/user/advanced/#event-hooks This could allow devs to register custom authentication methods. IE: ```python class MyAuth: async def do_custom_auth(self,...

Perhaps. But it would be useful to provide a means of doing so. Do you agree?

Agreed. However this would still require a refactor of the library's API to support something like ntlm auth where you will need to reuse connections.  Sent from Yahoo Mail on...