David Cook
David Cook
Confirming that we've reached feature parity, with an input field that appears when you choose "items", just like in the old screen.  But...
Ready to test with no conflicts!
As it's user-facing change, it would be good to provide a little more detail in the PR name. I'm not sure exactly how it will affect users, but I guess...
# Testing on staging They all loaded successfully before and after, so I can't make any conclusions. Note that CableReady is reporting as v5.0.1, even when it was actually 5.0.2....
🤔 Hmm, I guess I'd add notes to the new PR, and close it, signalling dependabot to ignore it until next version. Or maybe we can figure out how to...
Thanks Konrad, as you say, these errors are pre-existing (and probably indicate https://github.com/openfoodfoundation/openfoodnetwork/issues/12020 is still a problem). So I think this is fine to proceed.
> * `t.boolean "inherits_properties"` keep in product group. This flag actually depends on the supplier, which is now associated with the Variant, so I think we need to consider if...
Hi @filipefurtad0 , I went ahead and rebased this to prepare for merge. I condensed some of the past commits, and added some more fixes. I also added some "TODO"...
We can actually fix a lot of violations with rubocop's safe correction feature, and have a script for that. I propose we do as many safe corrections first, then we...
Hi @macanudo527 , we've updated this issue to provide a bit more structure on how we work through these. Would you be willing to take on the next step, which...