openfoodnetwork icon indicating copy to clipboard operation
openfoodnetwork copied to clipboard

Published 20 hours ago • verified publisher icon openfoodfoundation

Downgrade cable_ready JS to 5.0.1

Open dacook opened this issue 11 months ago • 2 comments

What? Why?

In order to match the gem version. Who knows, this might help with:

  • #11752
  • #12020

I tried to Bump cable_ready to 5.0.3, but it didn't work, so let's try this instead. It's still compatible with the current version of StimulusReflex.

I don't know if I'm using yarn wrong, but it wanted to install a newer version alongside this version, in order to resolve cable_ready@^5.0.0. I manually edited the lockfile and yarn install now works as expected.

What should we test?

Functions that use StimulusReflex, which includes:

  • Bulk edit products (admin_style_v3)
  • Bulk orders actions (send invoice etc)

Release notes

Changelog Category (reviewers may add a label for the release notes):

  • [ ] User facing changes
  • [ ] API changes (V0, V1, DFC or Webhook)
  • [x] Technical changes only
  • [ ] Feature toggled

The title of the pull request will be included in the release notes.

Dependencies

Documentation updates

dacook avatar Mar 06 '24 23:03 dacook

Testing on staging

They all loaded successfully before and after, so I can't make any conclusions. Note that CableReady is reporting as v5.0.1, even when it was actually 5.0.2.

fr_staging before

fr_staging-master

fr_staging after

fr_staging-downgrade

au_staging before

au_staging-before

au_staging after

au_staging-downgrade

uk_staging after

even with extremely large list of variants: uk_staging-downgrade

dacook avatar Mar 07 '24 00:03 dacook

🤔 Hmm, I guess I'd add notes to the new PR, and close it, signalling dependabot to ignore it until next version. Or maybe we can figure out how to upgrade to the current version 5.0.3 next time. Or Hopefully the next version works better..

dacook avatar Mar 07 '24 06:03 dacook

Hi @dacook, Thanks for the test instructions.

  • For bulk editing products with Admin Styles v3 active, I get CableReady errors in the browser console. However, they are visible in current master as well. So probably not related to this PR. grafik

  • With Admin Styles v3 NOT active, there are no errors. Working as expected.

  • Bulk actions on orders are working fine for Admin Styles v3 and regular Admin Styles.

I'll add the feedback-needed label and await your comment regarding the CableReady errors.

Thanks again!

drummer83 avatar Mar 20 '24 14:03 drummer83

Thanks Konrad, as you say, these errors are pre-existing (and probably indicate https://github.com/openfoodfoundation/openfoodnetwork/issues/12020 is still a problem).

So I think this is fine to proceed.

dacook avatar Mar 21 '24 00:03 dacook