David Cook
David Cook
FYI @chahmedejaz I created an issue to describe the problem here, and assigned you because you were assigned to the optimisation issue.
@rioug this is now unblocked but requires a conflict resolution
@rioug just double-checking after last week, can you think of anything that should be manually test on staging before we merge?
I think we need to specify the requirements more closely. I will take a look.
I think what we need is to ensure that the email (`ProducerMailer`) considers price when grouping line items (just like the `OrderCycleSupplierTotals` report does here: https://github.com/openfoodfoundation/openfoodnetwork/blob/23bcdc/lib/reporting/reports/orders_and_fulfillment/base.rb#L25-L29 But I'm wondering if...
Oh yeah! 😅 I'll update the suggested solution and add to Welcome New Developers.
For reference, this is the current interface. A new line can be added for payment status changes. And after creating, you can delete it: Optional extra: * Add a button...
I'm not sure about that. I think for a first version we would only include users that directly manage or own the distributor enterprise.
This looks like a big effort, well done! From a quick glance, I think this will be ready to review, after just [one more spec to fix](https://github.com/openfoodfoundation/openfoodnetwork/actions/runs/16456060153/job/46513275200?pr=13424). I'm also curious...
All good, thanks that helps to explain the context. We will review the code next week and let you know if any issues. Also just thinking about manual testing: we...