David Cook

Results 433 comments of David Cook

Thanks, updated the description.

Hi Marin and welcome! The tests do generally success on master on GitHub actions (although it's true some can perform differently when running on a development environment). I went ahead...

Probably worth mentioning that it's necessary to test that no changes are saved as a result of the preview; only after clicking import.

Also occurred in Hungary once. [This feature](https://github.com/openfoodfoundation/openfoodnetwork/pull/12653) was developed in August last year, so it's interesting that the error's only just started occurring this month. Perhaps a conflict with a...

I had a go a replicating the deprecation warning, but couldn't get it to raise: `spec/lib/reports/orders_and_fulfillment/order_cycle_customer_totals_report_spec.rb` ``` order.line_items[0].final_weight_volume = nil report ```

Thanks for investigating, and good idea to update for consistency. It last occurred on 2 August in Hungary (27 occurrences at the same time). Perhaps due to very specific data,...

I searched all bugsnag projects for the main account the French account, and couldn't find any mention of this error.

Matt also mentions that: > Our current reports and places where tax adjustments are displayed can handle both types. Because we no longer use the old type, I wondered if...

I guess we need to keep `compute_item`, but haven't investigated. If that's the case, maybe we can remove the Spree::Order case and keep the item one. ```diff case computable -...

Adds ability for two OFN instances to talk together (or the same instance talking to itself). ### Use Case * OFN1 instance has Distributor (who is supplier who sells own)...