David Cook

Results 433 comments of David Cook

Thanks Mohamed! I've merged but will keep this open as it doesn't yet cover the new products_v3 screen. Here are some suggestions for next steps, what do you think? 1....

It looks like we need to work through the requirements a little more before this is ready to develop. In addition to the above queries, I'd like to know: *...

For **URL format**, I would suggest that we use the product name, similar to how we use shop names. I've implemented this on another project and could make some more...

There's also a design consideration. It is changing the capitalisation style to "Sentence case" to match the new design. But this issue shows that we can't enforce that with style...

There's a question about what happens if the translation is missing for the tab name. There's currently some special handling of that case. But a missing translation should be considered...

Ah, I should have known it wouldn't be a quick update afterall. Specs look like an easy fix. But no, I haven't checked if the default value is tested, it's...

@mkllnk , just wondering if you have a plan for the migrations? Shall we include them as a final step before closing https://github.com/openfoodfoundation/openfoodnetwork/issues/12448 ? PS I updated the release notes...

Hi @mariocarabotta, while debugging an issue on staging servers, I tried adding these indicators to show when a row has been updated or has errors. We had an issue with...

Discussed with @mariocarabotta : it's complicated to get this right, with a few things to consider: For example, we already have a coloured bar on the top banner, with a...

@pacodelaluna I'm wondering if you have time to review these issues and can comment if they are still relevant or solved already?