David Cook

Results 433 comments of David Cook

With some experimenting I found it's due to the "None" (empty) tax category. Will have a look at what we chagned recently. Also thinking about how we can surface unexpected...

Turned this off on au_staging and it now works :D ![Screenshot 2024-05-15 at 4 52 04 pm](https://github.com/openfoodfoundation/openfoodnetwork/assets/4188088/112c60d9-091f-42c4-b1d0-8b9766cb3ca3) It was already off on fr_staging. I'm not exactly sure what the problem...

Still a problem, demonstrated in https://github.com/openfoodfoundation/openfoodnetwork/pull/12486#issuecomment-2123374715

I found the second cause of this above issue, described and proposed fix here: - https://github.com/openfoodfoundation/openfoodnetwork/pull/12521

Just came across another example of invalid data, in ca_prod: https://openfoodnetwork.ca/admin/products/22100/edit This product has no producer, but that's not valid. The producer dropdown is not set up to show an...

Although the dismiss button still doesn't work for invalid data, we decided to close because https://github.com/openfoodfoundation/openfoodnetwork/pull/12521 makes the invalid data a bit clearer, which helps the user to resolve by...

Fixed conflict with GitHub UI. Apparently that does a merge, will consider a manual rebase next time..

Hi both, thanks for discussing this. I'm sorry, I think I forgot to respond at the start of the week. The question is, what's the problem we're trying to solve?...

I guess there's a few levels we can optimise at, and I'm not sure what's practical. I think of at at a few levels: 1. Rails takes resources to load...

FYI @cyrillefr , I've identified that we also need to improve the performance on the backend (https://github.com/openfoodfoundation/openfoodnetwork/issues/12718) . Perhaps this is worth looking into instead?