David Capello

Results 701 comments of David Capello

> I've been looking through the code and didn't find any implemented method to, given two paths, return the relative path from one to another. That's right, that's a function...

Hi @gui-marc, although using `std::filesystem::relative()` and we are using some C++17 functions, we are adopting new APIs at a slow rate, because we want to still compile for macOS 10.9...

> I'm rewriting the method using only strings. That will be great @gui-marc, one possibility would be to add a new function in the laf base/fs.h for this (e.g. base::get_relative_path)....

I've just tested using: ![image](https://github.com/aseprite/aseprite/assets/39654/536f1ae9-a1a2-43db-8c47-36f82b1180d8) And then exporting again will show: ![image](https://github.com/aseprite/aseprite/assets/39654/d85a4fa5-f41c-447b-b79b-64be9e3dd251) About the `split()` function, you can use `base::split_string()`.

And please remove all trailing whitespaces before committing: ![image](https://github.com/aseprite/aseprite/assets/39654/5180372f-6778-437e-89a9-16aa55d9bdfd)

@gui-marc due to GitHub limitations, I can: 1) cherry pick https://github.com/dacap/aseprite/commit/549f523fae51514e2503c1e7abbf9e5a1accc367 (with the laf submodule update + minor commit description changes/code formatting changes) and close this PR, or 2) you...

> @dacap I rebased it with [dacap@549f523](https://github.com/dacap/aseprite/commit/549f523fae51514e2503c1e7abbf9e5a1accc367) but it added the previous commits in this PR (is this right?). No, your branch should contain just one extra commit from the...

Thanks for your PR and patience @gui-marc to continue working on this fix :+1:

Hi @ballerburg9005, your comment includes a set of new features: - [ ] mouse buttons (+ keyboard modifiers) should be mappable as keyboard shortcuts to commands (e.g. undo/redo, toggle symmetry,...

Hi @patrickmeehan, thanks a lot for this PR! I'll review ASAP. Remember to sign the CLA email you've received to complete the [CLA signing process](https://github.com/igarastudio/cla?tab=readme-ov-file#signing).