David Capello
David Capello
One last time at the moment is if we can merge dropResult/acceptDrop in some way, or explain when each field must be set/used on each event (and if we need...
> We can remove the acceptDrop field and let DragTarget::drop return a boolean that indicates if the drop was accepted or not. Something similar could be done for DragTarget::dragEnter and...
As we talked the other time, probably we can make the laf library depends on the clip library. I can prepare this change on aseprite and laf main branch moving...
> the thing was that the code in the clip library doesn't use os::Surface. So I think I will have to figure out how to interface from laf to the...
The `clip` module is available in the `main` branch now.
> Oh, just in case, in the clip library there is another comptr implementation in clip_win_wic.h...which seems like incomplete or something (for instance it doesn't call AddRef() in any method)....
I fear that this PR might be impossible to review if gets to big. It might be interesting to think an approach were we merge first the macOS impl, then...
I'll start reviewing this right now. So in some way I don't expect new commits until it's reviewed or merged.
Hi @Picar0r, it looks like you don't have skia compiled in /skiadir Probably you should use something like: ``` cmake -G Ninja \ -DLAF_BACKEND=skia \ -DSKIA_DIR=/home/m/laf/build/skiadir \ -DSKIA_LIBRARY_DIR=/home/m/laf/build/skiadir/out/Release-x64 ```
Sorry, as you had `skia library dir: /home/m/laf/build/skiadir/out/Release-x64` in your output I thought you have a copy of the compiled Skia library in that directory. Some points: 1) Please check...