Dave Abrahams

Shouldn't `ASTWalkObserver` be `ASTWalkVisitor`?

2

https://github.com/hylo-lang/hylo/blob/0ac60770a35b8360e315eec79dbd82cc6fbd0bb5/Sources/Core/AST/AST%2BWalk.swift#L3-L27 Observer is a different (and very reference-semantic-y) design pattern and this looks much more like a visitor to me. Also, why `traverse` instead of `visit`? Also, IMO the kind...

I got this error: ``` x.hylo:51.31-41: error: type 'Slice' does not conform to trait 'CollectionCore' type Slice: Collection { ~~~~~~~~~~ x.hylo:51.31-41: note: trait 'CollectionCore' requires function 'position(after:)' with type '[{self:...

`AST`s aren't `Equatable`?

9

Maybe I knew this and understood why at one point but now I find it really problematic. Sure makes it hard to validate serialization! [This failure](https://github.com/hylo-lang/hylo/actions/runs/7149367143/job/19471462695?pr=1205#step:4:2267) suggests ASTs don't make...

This just happened for me: ``` Test Suite 'DriverTests' started at 2023-12-02 08:40:42.168. Test Case '-[DriverTests.DriverTests testBinary]' started. Swift/Integers.swift:1603: Fatal error: Distance is not representable in Int error: Exited with...

Failing test

3

[This commit](https://github.com/hylo-lang/hylo/pull/1143/commits/d2038b395551ffa7ca2d6a2257570c9a08d48e06) should pass tests as far as I can tell, but RangeTests fails. ``` /Users/dave/src/hylo/Tests/LibraryTests/TestCases/RangeTests.hylo:1: error: -[LibraryTests.LibraryTests test_compileAndRun_RangeTests] : success was expected, but processing failed with thrown error: NonzeroExit(...

TypeChecker docs could be improved

2

These are just some things I noticed; I haven't done a full review. [this one](https://github.com/hylo-lang/hylo/blame/230560c3ee8bf98ad76c48ea28f98dbd2b27a3b0/Sources/FrontEnd/TypeChecking/TypeChecker.swift#L494-L496) is wordy and hard to understand. What can we do to make it cleaner? Also...

Optimize performance / energy use of GitHub actions

6

- Documentation extraction depends on the same build steps that the regular build/test does, use [dependent jobs](https://www.edwardthomson.com/blog/github_actions_17_dependent_jobs.html) to do the build steps once for both cases - LLVM setup is...

`Deinitializable` conformance not synthesized for lambda type

1

Compile this with 3166db52: ``` fun f() { let x = fun (_ target: set T) -> Void { &target = src.copy() } _ = x } public fun main()...

Instead of [this approach](https://github.com/hylo-lang/hylo/issues/932), we could instead copy the standard library sources but add `#file` and `#line` directives so that diagnostics point to the original source files. Just a thought.

Reconsider this API: ``` PointerToMutable.allocate_bytes(count: 2, aligned_at: 1) ```