Dave Abrahams

https://github.com/realm/jazzy?tab=readme-ov-file#documenting-multiple-modules

Making the project depend on `swift-format` hurts development velocity

5

Every clean build, causes a re-fetch of the repository and a build of all the sources for `swift-format`. Making sure everyone is using exactly the same version is not worth...

Silence name lookup diagnostics stemming from declarations having been assigned an error type

5

At 30dacf0f8 ``` //- compileAndRun expecting: success fun test_rotate() { var a = Array() &a.append(0) &a.append(1) &a.append(2) &a.append(3) &a.append(4) &a.append(5) &a.append(6) &a.append(7) &a.append(8) &a.append(9) var i = 0 while i

Running the driver on a Deserializing AST triggers failures only in release builds

10

Only in release builds, on the [serialization-mystery branch](https://github.com/hylo-lang/hylo/tree/serialization-mystery), I'm getting this failure: > Emitter.swift:2131: Fatal error: Generate IR for calls to local functions with captures #1088 reproduce with `swift test...

https://github.com/hylo-lang/hylo/blob/14ebb255d9ad2105bd28291d9e0041f3a2fe42a4/Tools/run-swift-format.sh#L9 hardcodes information that [could be computed](https://github.com/hylo-lang/hylo/blob/14ebb255d9ad2105bd28291d9e0041f3a2fe42a4/.github/workflows/doc-extraction.yml#L70-L74). /cc @lucteo

Force `XCTAssert` to use `#filePath`

8

When developing at the command-line, failures without full path info (which XCTest used to emit but no longer does) tend to cause problems for IDEs.

Examples in docs should be tested

4

We ought to run the documentation through a tool that extracts examples and tests them. I have written such a tool before and would be happy to consult on the...

`using` is a vacuous argument label

8

Every function does what it does “using” its arguments. If we can't find a better label, [this one](https://github.com/val-lang/val/blob/main/Sources/FrontEnd/Parse/ParserState.swift#L256) should just be removed everywhere it appears in our codebase.

Nondeterministic test failure

5

I've seen this happen several times (without parallel testing enabled FWIW): ``` Test Case '-[LibraryTests.LibraryTests test_compileAndRun_OptionalTests]' started. /Users/dave/src/hylo/Tests/LibraryTests/TestCases/OptionalTests.hylo:1: error: -[LibraryTests.LibraryTests test_compileAndRun_OptionalTests] : success was expected, but processing failed with thrown...

Shouldn't `ASTWalkObserver` be `ASTWalkVisitor`?

2

https://github.com/hylo-lang/hylo/blob/0ac60770a35b8360e315eec79dbd82cc6fbd0bb5/Sources/Core/AST/AST%2BWalk.swift#L3-L27 Observer is a different (and very reference-semantic-y) design pattern and this looks much more like a visitor to me. Also, why `traverse` instead of `visit`? Also, IMO the kind...