Danny Garside

Results 237 comments of Danny Garside

Looks like `object-fit: scale-down` is what is needed. I think this would make a sensible default, but there may be examples where it is not, that I'm not thinking of.

@mmcky / @choldgraf - did this issue get moved/duplicated elsewhere?

I *really* like this. Mainly for https://github.com/executablebooks/sphinx-book-theme/pull/454 fixing https://github.com/executablebooks/jupyter-book/issues/950 which has been a pet peeve of mine for a while. What do others think?

> Hi @da5nsy, The executable book team will be releasing a new version, can we update that in PR #2307 when it's out to sync it with main? Hi @malvikasharan,...

Closing following the merging of #2307

Hey @aleesteele - this linking method isn't [the one stipulated in the style guide](https://the-turing-way.netlify.app/community-handbook/style/style-crossref.html). I've [requested that the PR be modified](https://github.com/alan-turing-institute/the-turing-way/pull/2711#pullrequestreview-1137750691), but I thought I should flag here in case...

The markdown within response blocks does not render (see https://github.com/Remi-Gau/the-turing-way/issues/1). Is this the intended behavior?

The order is different to current. Intended? ![image](https://user-images.githubusercontent.com/3739866/165011866-1fe2b24c-2048-4d1d-a0d5-4cf006333854.png) ![image](https://user-images.githubusercontent.com/3739866/165011950-88e7e5cf-4505-4baf-bbb4-2cf88fad297e.png)

Waiting on #2313, so that I can visually check the build, before marking as 'Ready for review'

So, this improved some situations: but makes others worse: I think what we really want is a 'max height' or a 'keep aspect ratio' tag.