Derek Pisner
Derek Pisner
Yeah I really like this and I think it would work nicely as an interface in core/interfaces because nearly all of the images to be plotted live in the workflow...
So with wm + csf segmentation overlays, it could be something like: ``` def plot_t1w_with_segs(t1w, wm, csf): """Plot t1w images using plotly. Parameters ---------- t1w : str Path to a...
Here's some of my scratchwork we can work with-- it will need to be modified to use rasb-ts. get_params may be a part of niworkflows already? ``` def id_outliers_fn(outlier_report, threshold,...
Great, I will proceed to write some unit tests for it then (unless @oesteban has any additional revision requests).
All of your suggested changes committed @oesteban :-) Merge?
Thanks @josephmje . I've updated the PR with your review.
> Looks good. I would improve docstrings and adding unit tests would be very much appreciated. Also left some food for thoughts regarding the nibabel manipulations - they'd better be...
@josephmje -- I went ahead on the latest commit and modified the out_path behavior, but now I see that you have been tackling this in #81 . Would you mind...
> > @josephmje -- I went ahead on the latest commit and modified the out_path behavior, but now I see that you have been tackling this in #81 . Would...
@josephmje @oesteban -- I've added all doctests for this and rebased the PR to the changes already merged in #81, which I noticed was already closed. Folks may want to...