d0cd
d0cd
Thank you for doing the research @ungaro! I agree with your analysis and like the overall approach. Left some comments on mainly focused on making the implementation more lightweight and...
Echoing @ljedrz, parsing is currently not-designed to be a "context-aware" operation. These checks are currently performed when generating and verifying a deployment. Are there any lightweight checks we should be...
That sounds like a reasonable thing to do!
> Yes I think we can port the `test-examples.sh` over, probably bringing the examples into this repo though. Is there a way to keep the `leo-examples` in a separate repo?...
> Are we sure we like the design with the upgrade mode config in `program.json` ? This is a fair question. Ultimately, it comes down to what we're trying to...
> Here's a few random comments. I want to be able to exercise this code before I approve though. @mikebenfield I've updated the [snarkOS PR](https://github.com/ProvableHQ/snarkOS/pull/3638). You should now be able...
> One thing that's not clear to me is how we expect this to roll out. Are we going to allow programs with no constructors or not? Are we going...
Making a self note. This design allows pinning dependencies of the call graph, however, it does not cover all dependencies. For example, an external mapping read might be to an...
@vicsn correct me if I missed something, but most, if not all changes have landed with upgradability (with some adjustments). This PR can be closed.
As of now, this is only partially handled in #28601 and needs some more discussion.